<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] support Computed Property Names in destructuring Patterns"
href="https://bugs.webkit.org/show_bug.cgi?id=151494">bug 151494</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #265956 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] support Computed Property Names in destructuring Patterns"
href="https://bugs.webkit.org/show_bug.cgi?id=151494#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] support Computed Property Names in destructuring Patterns"
href="https://bugs.webkit.org/show_bug.cgi?id=151494">bug 151494</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=265956&action=diff" name="attach_265956" title="Patch">attachment 265956</a> <a href="attachment.cgi?id=265956&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=265956&action=review">https://bugs.webkit.org/attachment.cgi?id=265956&action=review</a>
r=me with some comments
<span class="quote">> Source/JavaScriptCore/ChangeLog:8
> + Add support for computed property names in destructuring BindingPatterns</span >
It's worth adding a link to the spec here.
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:891
> + consumeOrFail(COLON, "Expected ':' after property name");</span >
So this kind of expression is only allowed using the new feature you added recently that assigns to the rhs of the colon?
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:894
> + TreeExpression defaultValue = parseDefaultValueForDestructuringPattern(context);</span >
Can we add a test for this case?
<span class="quote">> Source/JavaScriptCore/tests/es6/destructuring_assignment_computed_properties.js:1
> +function test() {</span >
I think this test is great. But, it's a bit tricky to follow. Can you also add just a couple really straight forward tests?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>