<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r192436): Inspector Hanging under tryParseDestructuringPatternExpression"
href="https://bugs.webkit.org/show_bug.cgi?id=151324#c20">Comment # 20</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r192436): Inspector Hanging under tryParseDestructuringPatternExpression"
href="https://bugs.webkit.org/show_bug.cgi?id=151324">bug 151324</a>
from <span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=265765&action=diff" name="attach_265765" title="Proposal for further reducing re-parsing">attachment 265765</a> <a href="attachment.cgi?id=265765&action=edit" title="Proposal for further reducing re-parsing">[details]</a></span>
Proposal for further reducing re-parsing
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=265765&action=review">https://bugs.webkit.org/attachment.cgi?id=265765&action=review</a>
This seems like a more efficient approach. Can you merge it into your previous patch and rebase to trunk?
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:2727
> + ExpressionErrorClassifier classification(this);</span >
Let's call this classifier to match its class name.
<span class="quote">> Source/JavaScriptCore/parser/Parser.h:740
> + enum ErrorClass {</span >
Let's call this ExpressionErrorClass.
<span class="quote">> Source/JavaScriptCore/parser/Parser.h:748
> + , m_outerClassifier(parser->m_errorClassifier)</span >
Let's call this m_previous.
<span class="quote">> Source/JavaScriptCore/parser/Parser.h:759
> + void classifyError(ErrorClass classification)</span >
Let's call this classifyExpressionError.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>