<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Web Process crashes on reparenting a WebView with AC mode on"
href="https://bugs.webkit.org/show_bug.cgi?id=151139#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Web Process crashes on reparenting a WebView with AC mode on"
href="https://bugs.webkit.org/show_bug.cgi?id=151139">bug 151139</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151139#c11">comment #11</a>)
<span class="quote">> Basically, it would be applying this patch on top of Carlos's last one:
>
> --- a/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp
> +++ b/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp
> @@ -145,8 +145,10 @@ LayerTreeHostGtk::LayerTreeHostGtk(WebPage* webPage)
>
> bool LayerTreeHostGtk::makeContextCurrent()
> {
> - if (!m_layerTreeContext.contextID)
> + if (!m_layerTreeContext.contextID) {
> + m_context = nullptr;
> return false;
> + }
>
>
> I've tested this locally and it fixes the issue for me reliably, both in
> Release and Debug builds.
>
> Carlos, what do you think?</span >
I think you write too much :-) awesome analysis, and I agree with your solution, makeContextCurrent() is the one creating the context, so look like a good place to delete it also when the ID becomes 0. I'll submit a new patch. Thanks!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>