<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop instead of GMainLoop in AudioFileReaderGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=151256#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop instead of GMainLoop in AudioFileReaderGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=151256">bug 151256</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151256#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=265476&action=diff" name="attach_265476" title="Patch">attachment 265476</a> <a href="attachment.cgi?id=265476&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=265476&action=review">https://bugs.webkit.org/attachment.cgi?id=265476&action=review</a>
>
> > Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:380
> > + if (isMainThread()) {
> > + RefPtr<AudioBus> returnValue;
> > + auto threadID = createThread("AudioFileReader", [&returnValue, filePath, mixToMono, sampleRate] {
> > + returnValue = AudioFileReader(filePath).createBus(sampleRate, mixToMono);
> > + });
> > + waitForThreadCompletion(threadID);
> > +
> > + return returnValue;
> > + }
>
> Would RunLoop::run() not set up a nested main loop in case of running this
> in the main thread?</span >
Yes, but with the same main context, we need a different one to avoid deadlocks. Phil wrote the original code, so he should know the details.
<span class="quote">> What about the cases where the bus is created in a non-main WebWorker thread
> that's also managed via RunLoop, wouldn't that set up the nested loop?</span >
In that case a new RunLoop is created for the current thread. If those threads already a have a RunLoop running maybe we should always use a dedicated thread, though.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>