<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop instead of GMainLoop in AudioFileReaderGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=151256#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop instead of GMainLoop in AudioFileReaderGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=151256">bug 151256</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=265476&action=diff" name="attach_265476" title="Patch">attachment 265476</a> <a href="attachment.cgi?id=265476&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=265476&action=review">https://bugs.webkit.org/attachment.cgi?id=265476&action=review</a>
<span class="quote">>>>> Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:380
>>>> + }
>>>
>>> Would RunLoop::run() not set up a nested main loop in case of running this in the main thread?
>>>
>>> What about the cases where the bus is created in a non-main WebWorker thread that's also managed via RunLoop, wouldn't that set up the nested loop?
>>
>> Yes, but with the same main context, we need a different one to avoid deadlocks. Phil wrote the original code, so he should know the details.
>
> My bad, workers don't use RunLoop, they use a custom queue.</span >
On that note, the new code goes on to create a RunLoop object in the worker thread.
I'd rather avoid that, and just use a new thread regardless where the AudioBus creation is requested (the main thread or a worker thread).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>