<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment"
href="https://bugs.webkit.org/show_bug.cgi?id=149338#c105">Comment # 105</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment"
href="https://bugs.webkit.org/show_bug.cgi?id=149338">bug 149338</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=265543&action=diff" name="attach_265543" title="Patch">attachment 265543</a> <a href="attachment.cgi?id=265543&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=265543&action=review">https://bugs.webkit.org/attachment.cgi?id=265543&action=review</a>
<span class="quote">> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:846
> + auto protoObject = environment.add(propertyNames().derivedConstructorPrivateName);</span >
Nit: I would call this variable a different name after your renaming.
<span class="quote">> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:3857
> + if (m_resolvedArrowFunctionScopeContextRegister == nullptr)</span >
Style: I think it's official WebKit style to check "!m_resolved..." Instead of "m_resolved... == nullptr"
<span class="quote">> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:3863
> +void BytecodeGenerator::emitGetThisFromArrowFunctionLexicalEnvironment()</span >
Style: I would call this "emitLoad..." Instead of "emitGet..."
And the same below
<span class="quote">> Source/JavaScriptCore/runtime/Executable.cpp:137
> + , m_features((isInStrictContext ? StrictModeFeature : 0) | (isInArrowFunctionContext ? ArrowFunctionContextFeature : 0))</span >
This seems awkward, actually. I'm not sure why we just have
the features mean one thing here. I think it's probably better just
to have a separate property like you had before.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>