<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add SPI for handling inline link navigation for peek/pop"
href="https://bugs.webkit.org/show_bug.cgi?id=151270#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add SPI for handling inline link navigation for peek/pop"
href="https://bugs.webkit.org/show_bug.cgi?id=151270">bug 151270</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151270#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=265492&action=diff" name="attach_265492" title="Patch">attachment 265492</a> <a href="attachment.cgi?id=265492&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=265492&action=review">https://bugs.webkit.org/attachment.cgi?id=265492&action=review</a>
>
> > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:40
> > +@class _WKPreviewingElementInfo;
>
> “previewing element” sound a little weird, because the element isn’t doing
> any previewing, it is being previewed perhaps, so maybe
> _WKPreviewedElementInfo or _WKPreviewableElementInfo fit better.
> </span >
That's true. I think that _WKPreviewableElementInfo is the most accurate, but it's a little clumsy, maybe? Maybe it's fine. _WKPreviewedElementInfo sounds past-tense, so I don't like it as much. I changed it to _WKPreviewElementInfo for now, but I could be convinced that _WKPreviewableElementInfo is better.
<span class="quote">> > Source/WebKit2/UIProcess/API/Cocoa/_WKElementInfo.mm:59
> > + return _URL.get();
>
> Because BOOL is sometimes just an unsigned char, this will return NO if the
> URL pointer ends in a 0 byte, so you should !! it or explicitly compare to
> nil.</span >
Oh, yes, thank you!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>