<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - run-webkit-test should look in --root directory for LayoutTestRelay"
href="https://bugs.webkit.org/show_bug.cgi?id=150859#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - run-webkit-test should look in --root directory for LayoutTestRelay"
href="https://bugs.webkit.org/show_bug.cgi?id=150859">bug 150859</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=264882&action=diff" name="attach_264882" title="Patch">attachment 264882</a> <a href="attachment.cgi?id=264882&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=264882&action=review">https://bugs.webkit.org/attachment.cgi?id=264882&action=review</a>
<span class="quote">>> Tools/Scripts/webkitpy/port/base.py:1150
>> + self.set_option_default('_cached_root', root_directory)
>
> Can we use self.set_option() here instead of self.set_option_default()?</span >
I'm double checking.
self.set_option_default() is defined as follows:
def set_option_default(self, name, default_value):
return self._options.ensure_value(name, default_value)
And ensure_value is defined as follows:
def ensure_value(self, attr, value):
if not hasattr(self, attr) or getattr(self, attr) is None:
setattr(self, attr, value)
return getattr(self, attire)
So, we only set it if it doesn't have the attribute or the attribute is None.
We've already established that self.get_option('_cached_root') was false-y (that's how we got into this branch of code to begin with).
Therefore it should be equivalent to use self.set_option()</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>