<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop::Timer for ready state timer in MediaPlayerPrivateGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=150836#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop::Timer for ready state timer in MediaPlayerPrivateGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=150836">bug 150836</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=150836#c6">comment #6</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=150836#c5">comment #5</a>)
> > (In reply to <a href="show_bug.cgi?id=150836#c4">comment #4</a>)
> > > (In reply to <a href="show_bug.cgi?id=150836#c3">comment #3</a>)
> > > > (In reply to <a href="show_bug.cgi?id=150836#c2">comment #2</a>)
> > > > > Comment on <span class=""><a href="attachment.cgi?id=264690&action=diff" name="attach_264690" title="Patch">attachment 264690</a> <a href="attachment.cgi?id=264690&action=edit" title="Patch">[details]</a></span>
> > > > > Patch
> > > > >
> > > > > View in context:
> > > > > <a href="https://bugs.webkit.org/attachment.cgi?id=264690&action=review">https://bugs.webkit.org/attachment.cgi?id=264690&action=review</a>
> > > > >
> > > > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:208
> > > > > > +#if PLATFORM(GTK)
> > > > >
> > > > > Why not USE(GLIB) ?
> > > >
> > > > Because EFL doesn't support it
> > >
> > > But aren't they using Glib? If not it's quite silly because quite a few deps
> > > like GStreamer and libsoup have an implicit dependency on it already.
> >
> > They don't use glib sources in the RunLoop implementation and win cairo
> > either. See how setPriority is defined in RunLoop.h
> >
> > #if USE(GLIB) && !PLATFORM(EFL)
> > void setPriority(int);
> > #endif
> >
> > EFL has its own implementation of RunLoop and RunLoop::Timer using ecore.
>
> Alright :) So let's use the same ifdef as above for consistency then?</span >
And do you want me to submit an updated patch just for this?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>