<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop::Timer instead of GMainLoopSource in video sink"
href="https://bugs.webkit.org/show_bug.cgi?id=150807#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop::Timer instead of GMainLoopSource in video sink"
href="https://bugs.webkit.org/show_bug.cgi?id=150807">bug 150807</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=150807#c7">comment #7</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=264681&action=diff" name="attach_264681" title="Updated patch">attachment 264681</a> <a href="attachment.cgi?id=264681&action=edit" title="Updated patch">[details]</a></span>
> Updated patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=264681&action=review">https://bugs.webkit.org/attachment.cgi?id=264681&action=review</a>
>
> > Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:92
> > + m_timer.stop();
> > + LockHolder locker(m_sampleMutex);
>
> I'm still stuck on this. in requestRender() m_timer operation is protected,
> here it's not.</span >
It's not actually the timer what is protected, but the sample, we need to hold the lock for the condition wait.
<span class="quote">> Regarding previous behavior, timeoutSource was never cancelled after
> scheduling, except when WebKitVideoSinkPrivate was destroyed. This
> technically deviates from that.</span >
That's right, but I think it was not desirable. We always wait until the timer is actually fired. That means that if unlockSampleMutex() was called for whatever reason before the timer is fired, the sample is destroyed and the condition was released, so we don't keep waiting anymore. But the timer will be fired anyway, but will return early because sample is NULL (and unlocked = true). Stopping the timer we just avoid the callback to be called just to return.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>