<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:pnormand@igalia.com" title="Philippe Normand <pnormand@igalia.com>"> <span class="fn">Philippe Normand</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop::Timer for ready state timer in MediaPlayerPrivateGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=150836">bug 150836</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #264690 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop::Timer for ready state timer in MediaPlayerPrivateGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=150836#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop::Timer for ready state timer in MediaPlayerPrivateGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=150836">bug 150836</a>
from <span class="vcard"><a class="email" href="mailto:pnormand@igalia.com" title="Philippe Normand <pnormand@igalia.com>"> <span class="fn">Philippe Normand</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=264690&action=diff" name="attach_264690" title="Patch">attachment 264690</a> <a href="attachment.cgi?id=264690&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=264690&action=review">https://bugs.webkit.org/attachment.cgi?id=264690&action=review</a>
<span class="quote">>>>>>>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:208
>>>>>>> +#if PLATFORM(GTK)
>>>>>>
>>>>>> Why not USE(GLIB) ?
>>>>>
>>>>> Because EFL doesn't support it
>>>>
>>>> But aren't they using Glib? If not it's quite silly because quite a few deps like GStreamer and libsoup have an implicit dependency on it already.
>>>
>>> They don't use glib sources in the RunLoop implementation and win cairo either. See how setPriority is defined in RunLoop.h
>>>
>>> #if USE(GLIB) && !PLATFORM(EFL)
>>> void setPriority(int);
>>> #endif
>>>
>>> EFL has its own implementation of RunLoop and RunLoop::Timer using ecore.
>>
>> Alright :) So let's use the same ifdef as above for consistency then?
>
> And do you want me to submit an updated patch just for this?</span >
No.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>