<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:jdiggs@igalia.com" title="Joanmarie Diggs (irc: joanie) <jdiggs@igalia.com>"> <span class="fn">Joanmarie Diggs (irc: joanie)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix crash when trying to get bounding box of node without a renderer"
href="https://bugs.webkit.org/show_bug.cgi?id=116496">bug 116496</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>jdiggs@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix crash when trying to get bounding box of node without a renderer"
href="https://bugs.webkit.org/show_bug.cgi?id=116496#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix crash when trying to get bounding box of node without a renderer"
href="https://bugs.webkit.org/show_bug.cgi?id=116496">bug 116496</a>
from <span class="vcard"><a class="email" href="mailto:jdiggs@igalia.com" title="Joanmarie Diggs (irc: joanie) <jdiggs@igalia.com>"> <span class="fn">Joanmarie Diggs (irc: joanie)</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=116496#c0">comment #0</a>)
<span class="quote">> Consider merging
> <a href="https://chromium.googlesource.com/chromium/blink/+/">https://chromium.googlesource.com/chromium/blink/+/</a>
> f489bf99677ac37abb2fb3510cb50cb4ea22e3e4
>
> It's obviously not possible to get the bounding box of an unrendered
> node; the null check was accidentally reversed when two functions
> were combined in the previous change.</span >
Are you suggesting we merge the previous change:
<a href="https://chromiumcodereview.appspot.com/14740025/">https://chromiumcodereview.appspot.com/14740025/</a>
If it's just fixing the null check that was accidentally reversed, we don't have a need:
<a href="https://trac.webkit.org/browser/trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp#L850">https://trac.webkit.org/browser/trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp#L850</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>