<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop::Timer instead of GMainLoopSource in video sink"
href="https://bugs.webkit.org/show_bug.cgi?id=150807#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop::Timer instead of GMainLoopSource in video sink"
href="https://bugs.webkit.org/show_bug.cgi?id=150807">bug 150807</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=264600&action=diff" name="attach_264600" title="Patch">attachment 264600</a> <a href="attachment.cgi?id=264600&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=264600&action=review">https://bugs.webkit.org/attachment.cgi?id=264600&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:8
> + Since we always wait until the smaple is actually rendered we</span >
sample is misspelled here
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:78
> + // Use a higher priority than WebCore timers (G_PRIORITY_HIGH_IDLE + 20).
> + m_timer.setPriority(G_PRIORITY_HIGH_IDLE + 19);</span >
This code is compiled for EFL, too. But this code is glib-specific. Is that OK for that port? Compile failed.
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:140
> +struct _WebKitVideoSinkPrivate {</span >
This peculiar use of a leading underscore followed by a capital letter trespasses on namespace that is reserved for compiler implementation, I believe.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>