<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop::Timer instead of GMainLoopSource in video sink"
href="https://bugs.webkit.org/show_bug.cgi?id=150807#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use RunLoop::Timer instead of GMainLoopSource in video sink"
href="https://bugs.webkit.org/show_bug.cgi?id=150807">bug 150807</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=150807#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=264600&action=diff" name="attach_264600" title="Patch">attachment 264600</a> <a href="attachment.cgi?id=264600&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=264600&action=review">https://bugs.webkit.org/attachment.cgi?id=264600&action=review</a>
>
> > Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:90
> > + m_timer.stop();
> > + LockHolder locker(m_sampleMutex);
>
> Any reason behind this ordering? The m_timer is being operated on under a
> lock in requestRender().</span >
Tried to follow what previous code did. We don't need the lock to protect the timer I think
<span class="quote">> > Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:145
> > + if (currentCaps)
> > + gst_caps_unref(currentCaps);
>
> Why is this being dereferenced in the constructor?</span >
Oh, good catch, that was supposed to be in the destructor :-P</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>