<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Add support for ARIA 1.1 attribute 'aria-modal' for dialog and alertdialog"
href="https://bugs.webkit.org/show_bug.cgi?id=138566#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Add support for ARIA 1.1 attribute 'aria-modal' for dialog and alertdialog"
href="https://bugs.webkit.org/show_bug.cgi?id=138566">bug 138566</a>
from <span class="vcard"><a class="email" href="mailto:n_wang@apple.com" title="Nan Wang <n_wang@apple.com>"> <span class="fn">Nan Wang</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=264467&action=diff" name="attach_264467" title="patch">attachment 264467</a> <a href="attachment.cgi?id=264467&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=264467&action=review">https://bugs.webkit.org/attachment.cgi?id=264467&action=review</a>
<span class="quote">>> Source/WebCore/accessibility/AXObjectCache.cpp:145
>> + , m_currentAriaModalNode(nullptr)
>
> we should remove the pointer to m_currentAriaModalNode in our method that detects when nodes disappear.
> you can imagine if someone removed a tree that contains m_currentAriaModalNode, we could have a stale pointer</span >
In ariaModalNode() to get the current modal node, isNodeVisible(m_currentAriaModalNode) will check if the node is still there and set it to nullptr in updateCurrentAriaModalNode(). So that makes sure we are not accessing a stale pointer. Do you think that's enough?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>