<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - The OS/2 USE_TYPO_METRICS fsSelection flag is not taken into account"
href="https://bugs.webkit.org/show_bug.cgi?id=131839">bug 131839</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #263907 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - The OS/2 USE_TYPO_METRICS fsSelection flag is not taken into account"
href="https://bugs.webkit.org/show_bug.cgi?id=131839#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - The OS/2 USE_TYPO_METRICS fsSelection flag is not taken into account"
href="https://bugs.webkit.org/show_bug.cgi?id=131839">bug 131839</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=263907&action=diff" name="attach_263907" title="Patch iOS 2">attachment 263907</a> <a href="attachment.cgi?id=263907&action=edit" title="Patch iOS 2">[details]</a></span>
Patch iOS 2
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=263907&action=review">https://bugs.webkit.org/attachment.cgi?id=263907&action=review</a>
I’m saying review+, but please do *not* land this patch exactly as is.
<span class="quote">> Source/WebCore/platform/graphics/ios/FontServicesIOS.mm:38
> +static bool fontHasMathTable(CTFontRef ctFont)</span >
This function already exists in FontCocoa.mm. Please don’t write a second copy of it; instead lets find a way to share the existing function.
<span class="quote">> Source/WebCore/platform/graphics/ios/FontServicesIOS.mm:125
> + if (*(reinterpret_cast<const OpenType::UInt16*>(os2Data + fsSelectionOffset)) & useTypoMetricsMask) {</span >
I suggest writing a helper function to do this messy reinterpret_cast thing that is repeated four times.
<span class="quote">> Source/WebCore/platform/graphics/opentype/OpenTypeTypes.h:32
> +#if ENABLE(OPENTYPE_MATH)
> +#include "Glyph.h"
> +#endif</span >
I don’t understand why this include needs to be added to a header, when we aren’t touching the header otherwise. If this is needed in FontServicesIOS.mm, then please put it in there.
Also, the header isn’t mentioned in the change log.
Please don’t land this header change!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>