<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Add support for ARIA 1.1 attribute 'aria-modal' for dialog and alertdialog"
href="https://bugs.webkit.org/show_bug.cgi?id=138566#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Add support for ARIA 1.1 attribute 'aria-modal' for dialog and alertdialog"
href="https://bugs.webkit.org/show_bug.cgi?id=138566">bug 138566</a>
from <span class="vcard"><a class="email" href="mailto:n_wang@apple.com" title="Nan Wang <n_wang@apple.com>"> <span class="fn">Nan Wang</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=264430&action=diff" name="attach_264430" title="patch">attachment 264430</a> <a href="attachment.cgi?id=264430&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=264430&action=review">https://bugs.webkit.org/attachment.cgi?id=264430&action=review</a>
<span class="quote">>> Source/WebCore/accessibility/AccessibilityObject.cpp:1857
>> + for (Node* node = this->node(); node; node = node->parentNode()) {
>
> there might be some ancestorsOfKind method that is better here</span >
I see there's a ancestorsOfType method. But shouldn't we know the type of the ancestor first? Here the ariaModalNode can be any type right? Or is there another function to get the type of a node?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>