<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [GTK] Use a persistent main loop source in RunLoop glib implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=150590">bug 150590</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #264130 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [GTK] Use a persistent main loop source in RunLoop glib implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=150590#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [GTK] Use a persistent main loop source in RunLoop glib implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=150590">bug 150590</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=264389&action=diff" name="attach_264389" title="Patch for landing">attachment 264389</a> <a href="attachment.cgi?id=264389&action=edit" title="Patch for landing">[details]</a></span>
Patch for landing
Found the problem of the timeouts in the bots. I was cancelling the persistent source in RunLoop:stop(). In case of nested main loop, if there are pedning tasks in the parent loop, the source is invalidated and the pending tasks are never done. We don't really need to cancel the source on stop, since the main loop will be stopped anyway and the main context won't process more sources. So, this patch simply removes the set_ready_time to -1 line in RunLoop::stop()</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>