<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Clean binding generated code for attribute setters and getters"
href="https://bugs.webkit.org/show_bug.cgi?id=150446">150446</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Clean binding generated code for attribute setters and getters
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>WebCore JavaScript
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>youennf@gmail.com
</td>
</tr></table>
<p>
<div>
<pre>As pointed out by Ossy in <a class="bz_bug_link
bz_status_NEW "
title="NEW - IDL functions and attributes should be JSBuiltin by default if interface is marked as JSBuiltinConstructor"
href="show_bug.cgi?id=150438">bug 150438</a>, the binding generator code for custom attribute getters and/or setters should be fixed:
<span class="quote">> > Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:158
> > +EncodedJSValue jsTestJSBuiltinConstructorTestAttributeCustom(ExecState* state, JSObject* slotBase, EncodedJSValue thisValue, PropertyName)
> > +{
> > + UNUSED_PARAM(state);
> > + UNUSED_PARAM(slotBase);
> > + UNUSED_PARAM(thisValue);
> > + auto* castedThis = jsCast<JSTestJSBuiltinConstructor*>(slotBase);
> > + return JSValue::encode(castedThis->testAttributeCustom(*state));
> > +}
>
> state and slotBase parameters are used. thisValue is really unused,
> but in this case omitting the parameter name would be better.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>