<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Implement rendering frames timeline panel for GTK+ port"
href="https://bugs.webkit.org/show_bug.cgi?id=150392#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Implement rendering frames timeline panel for GTK+ port"
href="https://bugs.webkit.org/show_bug.cgi?id=150392">bug 150392</a>
from <span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=263677&action=diff" name="attach_263677" title="Patch">attachment 263677</a> <a href="attachment.cgi?id=263677&action=edit" title="Patch">[details]</a></span>
Patch
I don't think this will do the right thing when the debugger pauses and we use a nested run loop. Can you test it to see what happens?
I do think that it is a little weird that these events do not go through InspectorInstrumentation already. There is no event system in place to notify WK2 clients when specific domains have instrumentation enabled or disabled, so there's no good way to selectively add/remove RunLoopObservers only when necessary. Thus, it's put into TimelineAgent's start/stop code itself.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>