<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - NetworkProcess: DNS prefetch happens in the Web Process"
href="https://bugs.webkit.org/show_bug.cgi?id=147824#c28">Comment # 28</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - NetworkProcess: DNS prefetch happens in the Web Process"
href="https://bugs.webkit.org/show_bug.cgi?id=147824">bug 147824</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147824#c27">comment #27</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=263456&action=diff" name="attach_263456" title="Updated patch">attachment 263456</a> <a href="attachment.cgi?id=263456&action=edit" title="Updated patch">[details]</a></span>
> Updated patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=263456&action=review">https://bugs.webkit.org/attachment.cgi?id=263456&action=review</a>
>
> r=me</span >
Thanks!
<span class="quote">> > Source/WebKit2/WebProcess/WebProcess.cpp:167
> > + , m_dnsPrefetchedHostsCleanupHysteresis(std::bind(&WebProcess::dnsPrefetchedHostsCleanupHysteresisUpdated, this, std::placeholders::_1))
>
> Could have also been all in one line:
> , m_dnsPrefetchHysteresis([this] (HystererisState state) { if (state ==
> HysteresisState::Stopped) m_dnsPrefetchedHosts.clear(); });</span >
Yes, I thought about that, but discarded it to avoid the single line if, but being a single statement if it doesn't look that bad, I'll change it.
<span class="quote">> > Source/WebKit2/WebProcess/WebProcess.h:368
> > + WebCore::HysteresisActivity m_dnsPrefetchedHostsCleanupHysteresis;
>
> I prefer the naming: m_dnsPrefetchHystereris. This way when the activity
> stops, it is clearer that what stopped is a DNS prefetching activity.</span >
Agree</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>