<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mmaxfield@apple.com" title="Myles C. Maxfield <mmaxfield@apple.com>"> <span class="fn">Myles C. Maxfield</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - ASSERTION FAILED: markFontData in FontCascade::emphasisMarkHeight"
href="https://bugs.webkit.org/show_bug.cgi?id=150171">bug 150171</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #263161 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - ASSERTION FAILED: markFontData in FontCascade::emphasisMarkHeight"
href="https://bugs.webkit.org/show_bug.cgi?id=150171#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - ASSERTION FAILED: markFontData in FontCascade::emphasisMarkHeight"
href="https://bugs.webkit.org/show_bug.cgi?id=150171">bug 150171</a>
from <span class="vcard"><a class="email" href="mailto:mmaxfield@apple.com" title="Myles C. Maxfield <mmaxfield@apple.com>"> <span class="fn">Myles C. Maxfield</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=263161&action=diff" name="attach_263161" title="Patch">attachment 263161</a> <a href="attachment.cgi?id=263161&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=263161&action=review">https://bugs.webkit.org/attachment.cgi?id=263161&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/FontCascade.cpp:1236
> + return !glyphData.isEmpty();</span >
This function should return an Optional(GlyphData) instead of using an out param.
Also, the U16_* macros can be cleaned up.
<span class="quote">> Source/WebCore/platform/graphics/GlyphPage.h:53
> + bool isEmpty() const { return !glyph && !font; }</span >
Why don't you name this "invalid" or something? I'm not sure that "empty" is the best name.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>