<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:aakash_jain@apple.com" title="Aakash Jain <aakash_jain@apple.com>"> <span class="fn">Aakash Jain</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests does not copy all crash logs for layout test failures on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=150056">bug 150056</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #263542 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #263542 Flags</td>
<td>review?, commit-queue?
</td>
<td>
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #263628 Flags</td>
<td>
</td>
<td>review?, commit-queue?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests does not copy all crash logs for layout test failures on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=150056#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests does not copy all crash logs for layout test failures on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=150056">bug 150056</a>
from <span class="vcard"><a class="email" href="mailto:aakash_jain@apple.com" title="Aakash Jain <aakash_jain@apple.com>"> <span class="fn">Aakash Jain</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=263628&action=diff" name="attach_263628" title="Updated patch">attachment 263628</a> <a href="attachment.cgi?id=263628&action=edit" title="Updated patch">[details]</a></span>
Updated patch
We needed a new expectation earlier, since for the newly found crashes, we were creating TestResult and adding to the list of TestResults and needed a way to differentiate between both type of crashes (so as to create separate sections in html page). However since we re-structed the json file and both type of crashes are stored in separate sections of json, we can do away with adding a new expectation. We just need some flag to differentiate test crashes from these new crashes (so as to add to correct section in json file). I have now used TestResult.is_other_crash flag for the same. Please review.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>