<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - NetworkProcess: DNS prefetch happens in the Web Process"
href="https://bugs.webkit.org/show_bug.cgi?id=147824#c21">Comment # 21</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - NetworkProcess: DNS prefetch happens in the Web Process"
href="https://bugs.webkit.org/show_bug.cgi?id=147824">bug 147824</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262588&action=diff" name="attach_262588" title="Updated patch">attachment 262588</a> <a href="attachment.cgi?id=262588&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262588&action=review">https://bugs.webkit.org/attachment.cgi?id=262588&action=review</a>
<span class="quote">> Source/WebCore/loader/FrameLoaderClient.h:33
> +#include "DNS.h"</span >
We should keep the implementation of the virtual function out of the header, that way we don’t need to include DNS.h in this header. Generally speaking it’s not so valuable to have implementations of virtual functions in the header rather than a cpp file since it’s not common to be able to expand them in line at the call site.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:632
> + m_page->mainFrame().loader().client().prefetchDNS(downcast<Element>(*node).absoluteLinkURL().host());</span >
Are we guaranteed that m_page is non-null?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>