<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ddkilzer@webkit.org" title="David Kilzer (:ddkilzer) <ddkilzer@webkit.org>"> <span class="fn">David Kilzer (:ddkilzer)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests does not copy all crash logs for layout test failures on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=150056">bug 150056</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #262955 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests does not copy all crash logs for layout test failures on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=150056#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests does not copy all crash logs for layout test failures on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=150056">bug 150056</a>
from <span class="vcard"><a class="email" href="mailto:ddkilzer@webkit.org" title="David Kilzer (:ddkilzer) <ddkilzer@webkit.org>"> <span class="fn">David Kilzer (:ddkilzer)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262955&action=diff" name="attach_262955" title="Proposed patch">attachment 262955</a> <a href="attachment.cgi?id=262955&action=edit" title="Proposed patch">[details]</a></span>
Proposed patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262955&action=review">https://bugs.webkit.org/attachment.cgi?id=262955&action=review</a>
r=me, but please review comments.
<span class="quote">>> Tools/Scripts/webkitpy/common/system/crashlogs.py:122
>> + return basename.endswith(".crash")
>
> Why are there two spaces here?</span >
Please remove the double space before landing.
<span class="quote">>> Tools/Scripts/webkitpy/common/system/crashlogs.py:146
>> + test_name = process_name + "-" + str(pid)
>
> This is not great naming - it's not "test name" in this case.</span >
test_or_process_name might be a better variable name.
This change is not required to land the patch, but please consider changing it.
<span class="quote">>> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:310
>> + if not (any(process[0] == test for process in crashed_processes)):
>
> Are the outer parentheses necessary?</span >
Please remove outer parenthesis if not necessary.
<span class="quote">>> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:45
>> +(PASS, FAIL, TEXT, IMAGE, IMAGE_PLUS_TEXT, AUDIO, TIMEOUT, CRASH, CRASH_OTHER, SKIP, WONTFIX,
>
> Don't we need to add support for this new result everywhere? Bot watcher's dashboard and flakiness dashboard come to mind first. Maybe EWS too.
>
> But since these crashes are already in a separate section of the JSON, I don't see why we need a new result.</span >
I'm not sure what Alexey's concern is here. As long as this generates new results.html files without causing the Dashboards to fail in some way, the patch seems fine.
Please follow-up with Alexey before landing this.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>