<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - We should be able to clear search field recent searches based on time given"
href="https://bugs.webkit.org/show_bug.cgi?id=150019#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - We should be able to clear search field recent searches based on time given"
href="https://bugs.webkit.org/show_bug.cgi?id=150019">bug 150019</a>
from <span class="vcard"><a class="email" href="mailto:andersca@apple.com" title="Anders Carlsson <andersca@apple.com>"> <span class="fn">Anders Carlsson</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=150019#c9">comment #9</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=150019#c8">comment #8</a>)
> > Comment on <span class=""><a href="attachment.cgi?id=263184&action=diff" name="attach_263184" title="Patch v2">attachment 263184</a> <a href="attachment.cgi?id=263184&action=edit" title="Patch v2">[details]</a></span>
> > Patch v2
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=263184&action=review">https://bugs.webkit.org/attachment.cgi?id=263184&action=review</a>
> >
> > > Source/WebCore/platform/SearchPopupMenu.h:45
> > > +WEBCORE_EXPORT static void removeRecentSearches(std::chrono::system_clock::time_point modifiedSince);
> >
> > Indentation.
>
> Will fix.
>
> >
> > > Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm:135
> > > + RetainPtr<NSDictionary> emptyItemsDictionary = adoptNS([[NSDictionary alloc] init]);
> > > + RetainPtr<NSDictionary> emptyRecentSearchesDictionary = adoptNS([[NSDictionary alloc] initWithObjectsAndKeys:emptyItemsDictionary.get(), itemsKey, nil]);
> >
> > Can use auto here.
>
> What is the benefit of using auto? Is it more modern?</span >
It avoids having "NSDictionary" twice on one line.
<span class="quote">> >
> > > Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm:205
> > > + [recentSearchesPlist writeToFile:searchFieldRecentSearchesPlistPath() atomically:NO];
> >
> > Should be atomically:YES here.
>
> Darin suggested I should use atomically:NO because of the performance cost.</span >
I think the performance cost is negligible and not corrupting data is better.
<span class="quote">> > > Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:1085
> > > + WebCore::SearchPopupMenu::removeRecentSearches(modifiedSince);
> >
> > I don't think you should call into WebCore here. Why can't you just put the
> > contents of removeRecentSearches here?
>
> Originally I had the contents of removeRecentSearches in WebsiteDataStore,
> but Darin thinks we should not do
>
> #if PLATFORM(COCOA)
> #endif
>
> in WebsiteDataStore and it would be better to move this logic to the
> platform independent SearchPopupMenu file.</span >
Just call platformRemoveRecentSearches and implement it in WebsiteDataStoreCocoa.mm.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>