<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a WKWebView input delegate SPI"
href="https://bugs.webkit.org/show_bug.cgi?id=149646">bug 149646</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #262626 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a WKWebView input delegate SPI"
href="https://bugs.webkit.org/show_bug.cgi?id=149646#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a WKWebView input delegate SPI"
href="https://bugs.webkit.org/show_bug.cgi?id=149646">bug 149646</a>
from <span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262626&action=diff" name="attach_262626" title="Patch">attachment 262626</a> <a href="attachment.cgi?id=262626&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262626&action=review">https://bugs.webkit.org/attachment.cgi?id=262626&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:206
> +@property (nonatomic, weak, getter=_formDelegate, setter=_setFormDelegate:) id <_WKFormDelegate> _formDelegate;</span >
No need for getter=_formDelegate since it’s exactly the same as the property name.
Instead of comment (which is not entirely correct: the declaration is here for source compatibility, the implementation is what gives us binary compatibility) you can annotate this with WK_DEPRECATED(10_10, WK_MAC_TBA, 8_0, WK_IOS_TBA, "use _inputDelegate")
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:207
> +@property (nonatomic, weak, setter=_setInputDelegate:) id <_WKInputDelegate> _inputDelegate;</span >
This needs to be annotated with WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA) since it’s new.
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/_WKFormDelegate.h:27
> +#ifndef _WKFormDelegate_h
> +#define _WKFormDelegate_h</span >
We don’t use such guards in headers that include Objective-C declarations (unless the declarations themselves are guarded with #if __OBJC__), because they are only imported from Objective-C files, which use #import directives which don’t require such guards.
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/_WKFormDelegate.h:33
> +#import "_WKInputDelegate.h"</span >
This needs to be a framework-style import, <WebKit/_WKInputDelegate.h>, because this is a framework header.
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/_WKFormDelegate.h:36
> + * We are transitioning _WKFormDelegate to _WKInputDelegate. This header is here temporarily for binary compatibility and</span >
source compatibility
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/_WKInputDelegate.h:34
> +@protocol _WKFormInputSession;
> +@protocol _WKFocusedElementInfo;</span >
Please keep these sorted, c before r.
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/_WKInputDelegate.h:36
> +@protocol _WKInputDelegate <NSObject></span >
I believe that we should annotate the entire protocol with availability information, but I am not sure exactly how.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:298
> + self = [super init];
> + if (!self)
> + return nil;</span >
We usually save a line by writing this:
if (!(self = [super init]))
return nil;
<span class="quote">> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:5303
> + 37A64E5418F38E3C00EB30F1 /* _WKInputDelegate.h */,
> 37A64E5618F38F4600EB30F1 /* _WKFormInputSession.h */,
> + 2E7A94491BBD95C600945547 /* _WKFocusedElementInfo.h */,</span >
Can you keep these sorted?
<span class="quote">> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:53
> -#import "WKWebProcessPluginFrameInternal.h"
> -#import "WKWebProcessPlugInInternal.h"
> #import "WKWebProcessPlugInFormDelegatePrivate.h"
> +#import "WKWebProcessPlugInInternal.h"
> #import "WKWebProcessPlugInLoadDelegate.h"
> #import "WKWebProcessPlugInNodeHandleInternal.h"
> #import "WKWebProcessPlugInPageGroupInternal.h"
> #import "WKWebProcessPlugInScriptWorldInternal.h"
> +#import "WKWebProcessPluginFrameInternal.h"</span >
What’s this about? Seems unrelated to this patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>