<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Content Extensions] Content blocking rules are not consulted for pings (<a ping>)"
href="https://bugs.webkit.org/show_bug.cgi?id=149873#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Content Extensions] Content blocking rules are not consulted for pings (<a ping>)"
href="https://bugs.webkit.org/show_bug.cgi?id=149873">bug 149873</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262988&action=diff" name="attach_262988" title="Patch (fails one test)">attachment 262988</a> <a href="attachment.cgi?id=262988&action=edit" title="Patch (fails one test)">[details]</a></span>
Patch (fails one test)
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262988&action=review">https://bugs.webkit.org/attachment.cgi?id=262988&action=review</a>
This is great! We could probably land this without the one failing test, then address that in a different bug. Please upload another patch, which will probably be pretty close to landing
<span class="quote">> Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:173
> + } else if (blockedStatus == BlockedStatus::BlockedCookies) {
> + request.setAllowCookies(false);
> + }</span >
There are lots of places you use {} around single lines, which WebKit style doesn't like. <a href="https://www.webkit.org/coding/coding-style.html">https://www.webkit.org/coding/coding-style.html</a> Use Tools/Scripts/check-webkit-style to check this.
<span class="quote">> Source/WebCore/loader/PingLoader.cpp:96
> + request.setAllowCookies(false);</span >
Why not call processContentExtensionRulesForLoad with this request instead of making a new function processContentExtensionRulesForPing? I think that would be even cleaner.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>