<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] OSX linker doesn't understand --whole-archive"
href="https://bugs.webkit.org/show_bug.cgi?id=144557">bug 144557</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #262929 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] OSX linker doesn't understand --whole-archive"
href="https://bugs.webkit.org/show_bug.cgi?id=144557#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] OSX linker doesn't understand --whole-archive"
href="https://bugs.webkit.org/show_bug.cgi?id=144557">bug 144557</a>
from <span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262929&action=diff" name="attach_262929" title="Patch">attachment 262929</a> <a href="attachment.cgi?id=262929&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262929&action=review">https://bugs.webkit.org/attachment.cgi?id=262929&action=review</a>
Looks good, but I want to suggest one small thing before committing the patch.
<span class="quote">> Source/WebKit2/PlatformGTK.cmake:929
> + set(DARWIN_ADDITIONAL_LIBRARIES --library=c++)
> + set(DARWIN_ADDITIONAL_LDFLAGS -lGObjectDOMBindings)</span >
Do you mind renaming these to INTROSPECTION_ADDITIONAL_LIBRARIES and INTROSPECTION_ADDITIONAL_LDFLAGS to make it consistent with INTROSPECTION_ADDITIONAL_LIBRARY_PATH?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>