<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] OSX linker doesn't understand --whole-archive"
href="https://bugs.webkit.org/show_bug.cgi?id=144557#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] OSX linker doesn't understand --whole-archive"
href="https://bugs.webkit.org/show_bug.cgi?id=144557">bug 144557</a>
from <span class="vcard"><a class="email" href="mailto:philip.chimento@gmail.com" title="Philip Chimento <philip.chimento@gmail.com>"> <span class="fn">Philip Chimento</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144557#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=252688&action=diff" name="attach_252688" title="Patch">attachment 252688</a> <a href="attachment.cgi?id=252688&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=252688&action=review">https://bugs.webkit.org/attachment.cgi?id=252688&action=review</a>
>
> Seems sensible to me, but this patch needs a bit of work. Thanks!
>
> > Source/WebKit2/PlatformGTK.cmake:549
> > -ADD_WHOLE_ARCHIVE_TO_LIBRARIES(WebKit2_LIBRARIES)
> > +if (CMAKE_SYSTEM_NAME MATCHES "Linux")
> > + ADD_WHOLE_ARCHIVE_TO_LIBRARIES(WebKit2_LIBRARIES)
> > +endif ()
>
> It would be better to add this check to the ADD_WHOLE_ARCHIVE_TO_LIBRARIES
> macro instead of requiring it for every invocation.</span >
Sure. I'll also change it to NOT CMAKE_SYSTEM_MATCHES "Darwin" in order to be more specific like I did in #144555.
<span class="quote">> > Source/WebKit2/PlatformGTK.cmake:875
> > - COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations LDFLAGS=
> > + COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations LDFLAGS=-lGObjectDOMBindings
>
> This looks unrelated.</span >
These are related though; it's what I was referring to with "link with extra libraries instead" in the patch's changelog. Without --whole-archive, these libraries don't get picked up for linking, so I have to add them manually.
I wonder if it might make sense to get rid of the ADD_WHOLE_ARCHIVE_TO_LIBRARIES macro entirely, since all the necessary libraries are now added manually. Alternatively, I could bracket these manual additions inside CMAKE_SYSTEM_NAME checks.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>