<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] OSX linker doesn't understand --whole-archive"
href="https://bugs.webkit.org/show_bug.cgi?id=144557">bug 144557</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #252688 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] OSX linker doesn't understand --whole-archive"
href="https://bugs.webkit.org/show_bug.cgi?id=144557#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] OSX linker doesn't understand --whole-archive"
href="https://bugs.webkit.org/show_bug.cgi?id=144557">bug 144557</a>
from <span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252688&action=diff" name="attach_252688" title="Patch">attachment 252688</a> <a href="attachment.cgi?id=252688&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252688&action=review">https://bugs.webkit.org/attachment.cgi?id=252688&action=review</a>
Seems sensible to me, but this patch needs a bit of work. Thanks!
<span class="quote">> Source/WebKit2/PlatformGTK.cmake:549
> -ADD_WHOLE_ARCHIVE_TO_LIBRARIES(WebKit2_LIBRARIES)
> +if (CMAKE_SYSTEM_NAME MATCHES "Linux")
> + ADD_WHOLE_ARCHIVE_TO_LIBRARIES(WebKit2_LIBRARIES)
> +endif ()</span >
It would be better to add this check to the ADD_WHOLE_ARCHIVE_TO_LIBRARIES macro instead of requiring it for every invocation.
<span class="quote">> Source/WebKit2/PlatformGTK.cmake:875
> - COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations LDFLAGS=
> + COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations LDFLAGS=-lGObjectDOMBindings</span >
This looks unrelated.
<span class="quote">> Source/WebKit2/PlatformGTK.cmake:890
> + --library=c++</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>