<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Content Extensions] Content blocking rules are not consulted for pings (<a ping>)"
href="https://bugs.webkit.org/show_bug.cgi?id=149873#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Content Extensions] Content blocking rules are not consulted for pings (<a ping>)"
href="https://bugs.webkit.org/show_bug.cgi?id=149873">bug 149873</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262754&action=diff" name="attach_262754" title="Patch">attachment 262754</a> <a href="attachment.cgi?id=262754&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262754&action=review">https://bugs.webkit.org/attachment.cgi?id=262754&action=review</a>
Thanks! This is great! I think Brady should look at this.
<span class="quote">> Source/WebCore/loader/PingLoader.cpp:110
> startPingLoad(frame, request);</span >
I'm not sure that blocking right before this call to startPingLoad is the right place. There are two other calls to startPingLoad that are not covered by this.
<span class="quote">> LayoutTests/ChangeLog:3
> + Tests to ensure content blocking rules are respected for "<a ping>" pings</span >
Hooray! Tests!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>