<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: ARIA 1.1 implement aria-colcount, aria-colindex, aria-colspan, aria-rowcount, aria-rowindex and aria-rowspan"
href="https://bugs.webkit.org/show_bug.cgi?id=148967#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: ARIA 1.1 implement aria-colcount, aria-colindex, aria-colspan, aria-rowcount, aria-rowindex and aria-rowspan"
href="https://bugs.webkit.org/show_bug.cgi?id=148967">bug 148967</a>
from <span class="vcard"><a class="email" href="mailto:n_wang@apple.com" title="Nan Wang <n_wang@apple.com>"> <span class="fn">Nan Wang</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262789&action=diff" name="attach_262789" title="patch">attachment 262789</a> <a href="attachment.cgi?id=262789&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262789&action=review">https://bugs.webkit.org/attachment.cgi?id=262789&action=review</a>
For iOS I'm thinking of adding new methods to expose those values. I might open a new bug for iOS and tests. But seems iOS is not speaking table row/column count or indexes now.
<span class="quote">>> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:96
>> + unsigned rowSpan = ariaRowSpan();
>
> how do we distinguish 0 from no value?</span >
If no value, the function will return 1 as default.
<span class="quote">>> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:101
>> + rowSpan = 1;
>
> can you put this blob into a separate method</span >
Ok
<span class="quote">>> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:145
>> +}
>
> i know that column/rowIndex are used by VO to get data out of the table sometimes. will this mess things up?</span >
This is only for non-native tables, so I think the colspan/rowspan attributes won't be affected from this code. If author didn't set aria-colspan/aria-rowspan, the range.second will be 1 as before.
<span class="quote">>> Source/WebCore/accessibility/AccessibilityTable.cpp:695
>> + int rowCountInt = rowCountValue.toInt();
>
> if there's no aria_rowCount set, won't toInt() == 0? which seems like the wrong default value right</span >
My idea is to return the value only if the aria-rowcount is greater than the rendered table row count. Otherwise just return -1, and VO doesn't have to worry about speaking it.
The spec says: authors must set the value of aria-rowcount to -1 to indicate that the value should not be calculated by the user agent. Not sure if we should do something special about it.
<span class="quote">>> Source/WebCore/accessibility/AccessibilityTableRow.cpp:152
>> + for (unsigned i = 0; i < rowChildren.size(); i++) {
>
> are we able to use the better iterators for accessibility children
>
> for (const auto& cell in rowChildren)</span >
Ok</pre>
</div>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: ARIA 1.1 implement aria-colcount, aria-colindex, aria-colspan, aria-rowcount, aria-rowindex and aria-rowspan"
href="https://bugs.webkit.org/show_bug.cgi?id=148967#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: ARIA 1.1 implement aria-colcount, aria-colindex, aria-colspan, aria-rowcount, aria-rowindex and aria-rowspan"
href="https://bugs.webkit.org/show_bug.cgi?id=148967">bug 148967</a>
from <span class="vcard"><a class="email" href="mailto:n_wang@apple.com" title="Nan Wang <n_wang@apple.com>"> <span class="fn">Nan Wang</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262789&action=diff" name="attach_262789" title="patch">attachment 262789</a> <a href="attachment.cgi?id=262789&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262789&action=review">https://bugs.webkit.org/attachment.cgi?id=262789&action=review</a>
For iOS I'm thinking of adding new methods to expose those values. I might open a new bug for iOS and tests. But seems iOS is not speaking table row/column count or indexes now.
<span class="quote">>> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:96
>> + unsigned rowSpan = ariaRowSpan();
>
> how do we distinguish 0 from no value?</span >
If no value, the function will return 1 as default.
<span class="quote">>> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:101
>> + rowSpan = 1;
>
> can you put this blob into a separate method</span >
Ok
<span class="quote">>> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:145
>> +}
>
> i know that column/rowIndex are used by VO to get data out of the table sometimes. will this mess things up?</span >
This is only for non-native tables, so I think the colspan/rowspan attributes won't be affected from this code. If author didn't set aria-colspan/aria-rowspan, the range.second will be 1 as before.
<span class="quote">>> Source/WebCore/accessibility/AccessibilityTable.cpp:695
>> + int rowCountInt = rowCountValue.toInt();
>
> if there's no aria_rowCount set, won't toInt() == 0? which seems like the wrong default value right</span >
My idea is to return the value only if the aria-rowcount is greater than the rendered table row count. Otherwise just return -1, and VO doesn't have to worry about speaking it.
The spec says: authors must set the value of aria-rowcount to -1 to indicate that the value should not be calculated by the user agent. Not sure if we should do something special about it.
<span class="quote">>> Source/WebCore/accessibility/AccessibilityTableRow.cpp:152
>> + for (unsigned i = 0; i < rowChildren.size(); i++) {
>
> are we able to use the better iterators for accessibility children
>
> for (const auto& cell in rowChildren)</span >
Ok</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>