<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: ARIA 1.1 implement aria-colcount, aria-colindex, aria-colspan, aria-rowcount, aria-rowindex and aria-rowspan"
href="https://bugs.webkit.org/show_bug.cgi?id=148967#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: ARIA 1.1 implement aria-colcount, aria-colindex, aria-colspan, aria-rowcount, aria-rowindex and aria-rowspan"
href="https://bugs.webkit.org/show_bug.cgi?id=148967">bug 148967</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262789&action=diff" name="attach_262789" title="patch">attachment 262789</a> <a href="attachment.cgi?id=262789&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262789&action=review">https://bugs.webkit.org/attachment.cgi?id=262789&action=review</a>
whats the plan for exposing this on iOS?
<span class="quote">> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:96
> + unsigned rowSpan = ariaRowSpan();</span >
how do we distinguish 0 from no value?
<span class="quote">> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:101
> + rowSpan = 1;</span >
can you put this blob into a separate method
<span class="quote">> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:145
> +}</span >
i know that column/rowIndex are used by VO to get data out of the table sometimes. will this mess things up?
<span class="quote">> Source/WebCore/accessibility/AccessibilityTable.cpp:695
> + int rowCountInt = rowCountValue.toInt();</span >
if there's no aria_rowCount set, won't toInt() == 0? which seems like the wrong default value right
<span class="quote">> Source/WebCore/accessibility/AccessibilityTableRow.cpp:152
> + for (unsigned i = 0; i < rowChildren.size(); i++) {</span >
are we able to use the better iterators for accessibility children
for (const auto& cell in rowChildren)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>