<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WebCore::IOSurface should ask the IOSurface for the pixel format instead of caching it"
href="https://bugs.webkit.org/show_bug.cgi?id=149820">bug 149820</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #262470 is obsolete</td>
<td>1
</td>
<td>
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebCore::IOSurface should ask the IOSurface for the pixel format instead of caching it"
href="https://bugs.webkit.org/show_bug.cgi?id=149820#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebCore::IOSurface should ask the IOSurface for the pixel format instead of caching it"
href="https://bugs.webkit.org/show_bug.cgi?id=149820">bug 149820</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262470&action=diff" name="attach_262470" title="Patch">attachment 262470</a> <a href="attachment.cgi?id=262470&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262470&action=review">https://bugs.webkit.org/attachment.cgi?id=262470&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:242
> + if (pixelFormat == 'BGRA')
> + return Format::RGBA;</span >
I wonder if we should call the format BGRA since that's what it really is
<span class="quote">> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:243
> +#if PLATFORM(IOS)</span >
Why is this (and the other yuv stuff) iOS specific? Only the transform part should be iOS specific.
That will fix your build error, too.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>