<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - FTL is not working on Windows."
href="https://bugs.webkit.org/show_bug.cgi?id=145366#c56">Comment # 56</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - FTL is not working on Windows."
href="https://bugs.webkit.org/show_bug.cgi?id=145366">bug 145366</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262334&action=diff" name="attach_262334" title="Patch">attachment 262334</a> <a href="attachment.cgi?id=262334&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262334&action=review">https://bugs.webkit.org/attachment.cgi?id=262334&action=review</a>
I have a few nits about the build system changes.
<span class="quote">> Source/JavaScriptCore/CMakeLists.txt:846
> + if (NOT LLVM_STATIC_LIBRARIES AND NOT MSVC)</span >
Please use WIN32 instead of MSVC. It causes fewer warnings when running cmake and until someone builds webkit with mingw or clang, they're the same thing.
<span class="quote">> Source/JavaScriptCore/CMakeLists.txt:876
> + target_link_libraries(llvmForJSC "LLVMAnalysis.lib;LLVMAsmParser.lib;LLVMAsmPrinter.lib;LLVMBitReader.lib;LLVMBitWriter.lib;LLVMCodeGen.lib;LLVMCore.lib;LLVMDebugInfo.lib;LLVMExecutionEngine.lib;LLVMInstCombine.lib;LLVMInstrumentation.lib;LLVMInterpreter.lib;LLVMipa.lib;LLVMipo.lib;LLVMIRReader.lib;LLVMJIT.lib;LLVMLinker.lib;LLVMLTO.lib;LLVMMC.lib;LLVMMCDisassembler.lib;LLVMMCJIT.lib;LLVMMCParser.lib;LLVMObjCARCOpts.lib;LLVMObject.lib;LLVMOption.lib;LLVMRuntimeDyld.lib;LLVMScalarOpts.lib;LLVMSelectionDAG.lib;LLVMSupport.lib;LLVMTableGen.lib;LLVMTarget.lib;LLVMTransformUtils.lib;LLVMVectorize.lib;LLVMX86AsmParser.lib;LLVMX86AsmPrinter.lib;LLVMX86CodeGen.lib;LLVMX86Desc.lib;LLVMX86Disassembler.lib;LLVMX86Info.lib;LLVMX86Utils.lib;LLVMProfileData.lib")</span >
These should be in LLVM_STATIC_LIBRARIES.
<span class="quote">> Source/cmake/OptionsWin.cmake:39
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTL_JIT PRIVATE ON)</span >
Shouldn't this only be enabled for the 64-bit build?
<span class="quote">> Tools/Scripts/webkitdirs.pm:1888
> + if (isWin64()) {</span >
&& !canUseNinja()</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>