<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:msaboff@apple.com" title="Michael Saboff <msaboff@apple.com>"> <span class="fn">Michael Saboff</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=149619">bug 149619</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>msaboff@apple.com
</td>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>webkit-unassigned@lists.webkit.org
</td>
<td>msaboff@apple.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=149619#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=149619">bug 149619</a>
from <span class="vcard"><a class="email" href="mailto:msaboff@apple.com" title="Michael Saboff <msaboff@apple.com>"> <span class="fn">Michael Saboff</span></a>
</span></b>
<pre>I think I found the issue. In LowLevelAssembler.asm, the macro prepareForTailCall had the following construct:
if ARM or SH4 or ARM64 or C_LOOP or MIPS
addp 2 * PtrSize, sp
subi 2 * PtrSize, temp2
loadp PtrSize[cfr], lr
else
addp PtrSize, sp
subi PtrSize, temp2
loadp PtrSize[cfr], temp3
storep temp3, [sp]
end
The "if ARM or SH4 ..." case accounts for having a link register. The problem is that this if should also take into account the other ARM variants. It should read:
if ARM or ARMv7_TRADITIONAL or ARMv7 or SH4 or ARM64 or C_LOOP or MIPS
Running all JSC regression tests now.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>