<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:clopez@igalia.com" title="Carlos Alberto Lopez Perez <clopez@igalia.com>"> <span class="fn">Carlos Alberto Lopez Perez</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Build error with -DENABLE_SPELLCHECK=OFF"
href="https://bugs.webkit.org/show_bug.cgi?id=146904">bug 146904</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>cgarcia@igalia.com, clopez@igalia.com, mario@webkit.org, mrobinson@webkit.org
</td>
</tr>
<tr>
<td style="text-align:right;">Summary</td>
<td>[GTK] it can not built when -DENABLE_SPELLCHECK=OFF
</td>
<td>[GTK] Build error with -DENABLE_SPELLCHECK=OFF
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Build error with -DENABLE_SPELLCHECK=OFF"
href="https://bugs.webkit.org/show_bug.cgi?id=146904#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Build error with -DENABLE_SPELLCHECK=OFF"
href="https://bugs.webkit.org/show_bug.cgi?id=146904">bug 146904</a>
from <span class="vcard"><a class="email" href="mailto:clopez@igalia.com" title="Carlos Alberto Lopez Perez <clopez@igalia.com>"> <span class="fn">Carlos Alberto Lopez Perez</span></a>
</span></b>
<pre>I ACK this bug. When building WebKitGTK+ with -DENABLE_SPELLCHECK=OFF it fails to build with:
../../Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp:43:17: error: no type named 'TextCheckerEnchant' in namespace 'WebCore'; did you mean 'TextCheckerClient'?
static WebCore::TextCheckerEnchant& enchantTextChecker()
~~~~~~~~~^~~~~~~~~~~~~~~~~~
TextCheckerClient
../../Source/WebCore/page/EditorClient.h:63:7: note: 'TextCheckerClient' declared here
class TextCheckerClient;
^
../../Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp:45:36: error: no member named 'TextCheckerEnchant' in namespace 'WebCore'
static NeverDestroyed<WebCore::TextCheckerEnchant> checker;
~~~~~~~~~^
../../Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp:116:79: error: cannot initialize a parameter of type 'int *' with an lvalue of type 'int32_t' (aka 'int')
enchantTextChecker().checkSpellingOfString(text.toStringWithoutCopying(), misspellingLocation, misspellingLength);
^~~~~~~~~~~~~~~~~~~
../../Source/WebCore/platform/text/TextCheckerClient.h:47:57: note: passing argument to parameter 'misspellingLocation' here
virtual void checkSpellingOfString(StringView, int* misspellingLocation, int* misspellingLength) = 0;
^
../../Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp:142:58: error: too few arguments to function call, expected 3, have 1
guesses = enchantTextChecker().getGuessesForWord(word);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../Source/WebCore/platform/text/TextCheckerClient.h:58:5: note: 'getGuessesForWord' declared here
virtual void getGuessesForWord(const String& word, const String& context, Vector<String>& guesses) = 0;
^
../../Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp:152:26: error: no member named 'ignoreWord' in 'WebCore::TextCheckerClient'
enchantTextChecker().ignoreWord(word);
~~~~~~~~~~~~~~~~~~~~ ^
../../Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp:233:26: error: no member named 'updateSpellCheckingLanguages' in 'WebCore::TextCheckerClient'
enchantTextChecker().updateSpellCheckingLanguages(languages);
~~~~~~~~~~~~~~~~~~~~ ^
../../Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp:238:33: error: no member named 'loadedSpellCheckingLanguages' in 'WebCore::TextCheckerClient'
return enchantTextChecker().loadedSpellCheckingLanguages();
~~~~~~~~~~~~~~~~~~~~ ^</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>