<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement the comma instruction in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=149425#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement the comma instruction in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=149425">bug 149425</a>
from <span class="vcard"><a class="email" href="mailto:sukolsak@gmail.com" title="Sukolsak Sakshuwong <sukolsak@gmail.com>"> <span class="fn">Sukolsak Sakshuwong</span></a>
</span></b>
<pre>Thanks for the review!
(In reply to <a href="show_bug.cgi?id=149425#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=261694&action=diff" name="attach_261694" title="Patch">attachment 261694</a> <a href="attachment.cgi?id=261694&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=261694&action=review">https://bugs.webkit.org/attachment.cgi?id=261694&action=review</a>
>
> > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:1052
> > + void discard(int)
>
> Shouldn't this be ContextExpression?</span >
It could be Expression, but I think it would introduce indirectness and break the pattern that we've been using. Here is my answer to Mark's similar question: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Implement type conversion instructions in WebAssembly"
href="show_bug.cgi?id=149340#c4">https://bugs.webkit.org/show_bug.cgi?id=149340#c4</a>
<span class="quote">> ContextExpression is a macro for "typename Context::Expression". It is only used in the parser. Methods in the parser are templatized and take Context as the template parameter. The current possible Contexts are WASMFunctionSyntaxChecker WASMFunctionCompiler. In the future, we will have WASMFunctionLLVMIRGenerator.</span >
>
<span class="quote">> In the context of WASMFunctionSyntaxChecker or WASMFunctionCompiler, Expression is just a typedef of int, because we never use it. In the context of WASMFunctionLLVMIRGenerator, Expression will be a typedef of FTL::LValue (or LLVMValueRef.)</span >
>
<span class="quote">> I could use Expression, of course. But that seems to introduce unnecessary indirectness. I use the same design as the JSC parser. For example,</span >
>
<span class="quote">> - In parser/SyntaxChecker.h, we have "int createBreakStatement(const JSTokenLocation&, int, int) { return StatementResult; }"</span >
>
<span class="quote">> - In parser/ASTBuilder.h, we have "StatementNode* createBreakStatement(const JSTokenLocation& location, const Identifier* ident, const JSTextPosition& start, const JSTextPosition& end)"</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>