<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - New tests introduced in r188545 fail on 32 bit ARM"
href="https://bugs.webkit.org/show_bug.cgi?id=148376">bug 148376</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #261538 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - New tests introduced in r188545 fail on 32 bit ARM"
href="https://bugs.webkit.org/show_bug.cgi?id=148376#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - New tests introduced in r188545 fail on 32 bit ARM"
href="https://bugs.webkit.org/show_bug.cgi?id=148376">bug 148376</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=261538&action=diff" name="attach_261538" title="Patch">attachment 261538</a> <a href="attachment.cgi?id=261538&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261538&action=review">https://bugs.webkit.org/attachment.cgi?id=261538&action=review</a>
r=me with some nits.
<span class="quote">> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4641
> +#if !USE(JSVALUE32_64)</span >
nit: make this "USE(JSVALUE64)"
<span class="quote">> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4652
> +#if !USE(JSVALUE32_64)</span >
nit: make this "USE(JSVALUE64)"
<span class="quote">> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4671
> +#if !USE(JSVALUE32_64)</span >
ditto
<span class="quote">> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4705
> +#if !USE(JSVALUE32_64)</span >
ditto
<span class="quote">> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4709
> + m_jit.storePtr(thisValueTagGPR, MacroAssembler::Address(resultGPR, JSArrowFunction::offsetOfThisValue() + TagOffset));</span >
nit: I would also make this store32.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>