<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement indirect calls in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=149100">bug 149100</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #261077 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement indirect calls in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=149100#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement indirect calls in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=149100">bug 149100</a>
from <span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=261077&action=diff" name="attach_261077" title="Patch">attachment 261077</a> <a href="attachment.cgi?id=261077&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261077&action=review">https://bugs.webkit.org/attachment.cgi?id=261077&action=review</a>
r=me
<span class="quote">> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:610
> +
> + const Vector<JSFunction*>& functions = m_module->functionPointerTables()[functionPointerTableIndex].functions;
> + move(TrustedImmPtr(functions.data()), GPRInfo::regT0);
> + load32(temporaryAddress(m_tempStackTop - 1), GPRInfo::regT1);
> + m_tempStackTop--;</span >
Can you guarantee that the vector will never resize (and thus never change its data pointer)?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>