<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - printing does not use minimum page zoom factor"
href="https://bugs.webkit.org/show_bug.cgi?id=108507">bug 108507</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #260361 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - printing does not use minimum page zoom factor"
href="https://bugs.webkit.org/show_bug.cgi?id=108507#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - printing does not use minimum page zoom factor"
href="https://bugs.webkit.org/show_bug.cgi?id=108507">bug 108507</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260361&action=diff" name="attach_260361" title="Try to fix CG build">attachment 260361</a> <a href="attachment.cgi?id=260361&action=edit" title="Try to fix CG build">[details]</a></span>
Try to fix CG build
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260361&action=review">https://bugs.webkit.org/attachment.cgi?id=260361&action=review</a>
Looks OK to me.
<span class="quote">> Source/WebCore/page/PrintContext.cpp:320
> +int PrintContext::numberOfPages(Frame* frame, const FloatSize& pageSizeInPixels)</span >
Should take a Frame&. The caller is the one that checks for null.
<span class="quote">> Source/WebCore/page/PrintContext.cpp:329
> +void PrintContext::spoolAllPagesWithBoundaries(Frame* frame, GraphicsContext& graphicsContext, const FloatSize& pageSizeInPixels)</span >
Should take a Frame&. The caller is the one that checks for null.
<span class="quote">> Source/WebCore/page/PrintContext.cpp:347
> +#if PLATFORM(COCOA)
> graphicsContext.translate(0, totalHeight);
> graphicsContext.scale(FloatSize(1, -1));
> +#endif</span >
Seems bizarre that this is here. The platform layer is responsible for abstracting differences like this.
<span class="quote">> Source/WebCore/page/PrintContext.cpp:357
> +#if PLATFORM(COCOA)
> + int boundaryLineY = currentHeight;
> +#else
> + int boundaryLineY = currentHeight - 1;
> +#endif</span >
Same comment about the platform layer.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>