<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:berto@igalia.com" title="Alberto Garcia <berto@igalia.com>"> <span class="fn">Alberto Garcia</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] webkit 2.3.5 build failure with python 3.3.4"
href="https://bugs.webkit.org/show_bug.cgi?id=128971">bug 128971</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #225428 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #261222 Flags</td>
<td>
</td>
<td>review?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] webkit 2.3.5 build failure with python 3.3.4"
href="https://bugs.webkit.org/show_bug.cgi?id=128971#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] webkit 2.3.5 build failure with python 3.3.4"
href="https://bugs.webkit.org/show_bug.cgi?id=128971">bug 128971</a>
from <span class="vcard"><a class="email" href="mailto:berto@igalia.com" title="Alberto Garcia <berto@igalia.com>"> <span class="fn">Alberto Garcia</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=261222&action=diff" name="attach_261222" title="Patch">attachment 261222</a> <a href="attachment.cgi?id=261222&action=edit" title="Patch">[details]</a></span>
Patch
(In reply to <a href="show_bug.cgi?id=128971#c18">comment #18</a>)
<span class="quote">> Good find Berto. I tested Python 2.7.10 and
> 3.4.2. sys.stdout.encoding returns UTF-8 in both versions. But in
> Patrick's report above, it returns 646 in Python 3.3.4. I am
> presuming the version number is responsible for this difference</span >
Nah, it's not a problem with the Python version, it's the locale of
the build environment:
$ LC_ALL=C python2 ./Source/WebInspectorUI/Scripts/cssmin.py < ./Source/WebCore/xml/XMLViewer.css > /dev/null
$ LC_ALL=C python3 ./Source/WebInspectorUI/Scripts/cssmin.py < ./Source/WebCore/xml/XMLViewer.css > /dev/null
Traceback (most recent call last):
File "./Source/WebInspectorUI/Scripts/cssmin.py", line 46, in <module>
sys.stdout.write(cssminify(sys.stdin.read()))
File "/usr/lib/python3.4/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 642: ordinal not in range(128)
So if the locale is set to ascii, then python 3 expects the standard
input to be ascii, and otherwise it complains.
We can tell people to use UTF-8 for building WebKit, but we can also
force the stdin enconding using this patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>