<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Should use CARenderServerRenderLayerWithTransform for snapshots on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=149069">bug 149069</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #261010 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Should use CARenderServerRenderLayerWithTransform for snapshots on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=149069#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Should use CARenderServerRenderLayerWithTransform for snapshots on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=149069">bug 149069</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=261010&action=diff" name="attach_261010" title="Patch">attachment 261010</a> <a href="attachment.cgi?id=261010&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261010&action=review">https://bugs.webkit.org/attachment.cgi?id=261010&action=review</a>
<span class="quote">> Source/WebKit2/ChangeLog:11
> + This will let us own the backing IOSurface, which will let us make them
> + purgeable and share more code with Mac.</span >
Except we're not going to make them purgeable for now and it's not clear that that is actually the plan so maybe we shouldn't mention that part :D
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1110
> + auto surface = WebCore::IOSurface::create(WebCore::expandedIntSize(snapshotSize), WebCore::ColorSpaceDeviceRGB);</span >
We should do more perf testing here.
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1111
> + CARenderServerRenderLayerWithTransform(MACH_PORT_NULL, self.layer.context.contextId, reinterpret_cast<uint64_t>(self.layer), surface->surface(), 0, 0, &transform);</span >
I wonder if we have to use some other function on older OSes, like _snapshotWhatever does? Probably.
<span class="quote">> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h:-44
> -#if PLATFORM(MAC)</span >
YAYYYYY</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>