<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Should use CARenderServerRenderLayerWithTransform for snapshots on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=149069#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Should use CARenderServerRenderLayerWithTransform for snapshots on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=149069">bug 149069</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=149069#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=261010&action=diff" name="attach_261010" title="Patch">attachment 261010</a> <a href="attachment.cgi?id=261010&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=261010&action=review">https://bugs.webkit.org/attachment.cgi?id=261010&action=review</a>
>
> > Source/WebKit2/ChangeLog:11
> > + This will let us own the backing IOSurface, which will let us make them
> > + purgeable and share more code with Mac.
>
> Except we're not going to make them purgeable for now and it's not clear
> that that is actually the plan so maybe we shouldn't mention that part :D
> </span >
Fixed this!
<span class="quote">> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1110
> > + auto surface = WebCore::IOSurface::create(WebCore::expandedIntSize(snapshotSize), WebCore::ColorSpaceDeviceRGB);
>
> We should do more perf testing here.
> </span >
Perf bot watcher has been alerted!
<span class="quote">> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1111
> > + CARenderServerRenderLayerWithTransform(MACH_PORT_NULL, self.layer.context.contextId, reinterpret_cast<uint64_t>(self.layer), surface->surface(), 0, 0, &transform);
>
> I wonder if we have to use some other function on older OSes, like
> _snapshotWhatever does? Probably.
> </span >
Tim and I considered this, and he changed his mind.
<span class="quote">> > Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h:-44
> > -#if PLATFORM(MAC)
>
> YAYYYYY</span >
YAY. Thanks Tim!
<a href="http://trac.webkit.org/changeset/189628">http://trac.webkit.org/changeset/189628</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>