<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement internal calls in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=148998#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement internal calls in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=148998">bug 148998</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260849&action=diff" name="attach_260849" title="Patch">attachment 260849</a> <a href="attachment.cgi?id=260849&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260849&action=review">https://bugs.webkit.org/attachment.cgi?id=260849&action=review</a>
<span class="quote">>> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:685
>> + Vector<CallCompilationInfo> m_callCompilationInfo;
>
> You need to do something to GC this correctly. See our other handling of CallLinkInfo.</span >
I think he's doing it right already. The CallLinkInfos get added to a CodeBlock. The CodeBlock then knows what to do.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>