<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement the relational instructions in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=148838">bug 148838</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #260658 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement the relational instructions in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=148838#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement the relational instructions in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=148838">bug 148838</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260658&action=diff" name="attach_260658" title="Patch">attachment 260658</a> <a href="attachment.cgi?id=260658&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260658&action=review">https://bugs.webkit.org/attachment.cgi?id=260658&action=review</a>
r=me with comment
<span class="quote">> Source/JavaScriptCore/tests/stress/wasm-relational.js:119
> +var module = loadWebAssembly("wasm-relational.wasm");</span >
I think it'd be nicer to have a directory in stress called "wasm" that holds all the
wasm binaries were testing. Do we have other tests checked in that follow the
model in this patch? Maybe it's worth changing those.
Also, would it be possible to write the tests such that
we can write all wasm tests in JS, and have the loadWebAssembly do the
translation on the fly?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>