<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix crash due to animationDidEnd called on deallocated RemoteLayerTreeHost"
href="https://bugs.webkit.org/show_bug.cgi?id=148442">bug 148442</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>thorton@apple.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix crash due to animationDidEnd called on deallocated RemoteLayerTreeHost"
href="https://bugs.webkit.org/show_bug.cgi?id=148442#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix crash due to animationDidEnd called on deallocated RemoteLayerTreeHost"
href="https://bugs.webkit.org/show_bug.cgi?id=148442">bug 148442</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=148442#c6">comment #6</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=259977&action=diff" name="attach_259977" title="Patch">attachment 259977</a> <a href="attachment.cgi?id=259977&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=259977&action=review">https://bugs.webkit.org/attachment.cgi?id=259977&action=review</a>
>
> >> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:145
> >> m_layers.remove(layerID);
> >
> > 1) You can do the hash table lookup only once.
> >
> > 2) Should you also cover the case in clearLayers()?
>
> 1. Good point. Fixed.
>
> 2. clearLayers is only invoked in the destructor of RemoteLayerTreeHost,
> which ensures that all animation delegates are first invalidated. It might
> be better to lift the invalidation logic from ~RemoteLayerTreeHost to
> clearLayers() instead though.</span >
Ah! No, that's probably fine. OK.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>