<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] "method" property for the webkitwebsrc element"
href="https://bugs.webkit.org/show_bug.cgi?id=148433">bug 148433</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #259847 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] "method" property for the webkitwebsrc element"
href="https://bugs.webkit.org/show_bug.cgi?id=148433#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] "method" property for the webkitwebsrc element"
href="https://bugs.webkit.org/show_bug.cgi?id=148433">bug 148433</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259847&action=diff" name="attach_259847" title="patch">attachment 259847</a> <a href="attachment.cgi?id=259847&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259847&action=review">https://bugs.webkit.org/attachment.cgi?id=259847&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:116
> + GUniquePtr<gchar> method;</span >
method is quite confusing name, we can't change the property name, of course, but at least the variable could be httpMethod or something like that, I didn't know what this was about until I read the full patch.
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:269
> + 0, static_cast<GParamFlags>(G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));</span >
nullptr.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>