<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ThreadedCompositor] Use WTF::Condition together with WTF::Lock"
href="https://bugs.webkit.org/show_bug.cgi?id=148493">148493</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[ThreadedCompositor] Use WTF::Condition together with WTF::Lock
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Local Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>New Bugs
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>emanuele.aina@collabora.com
</td>
</tr></table>
<p>
<div>
<pre>The recent switch to WTF::Lock results in build failures with ENABLE_THREADED_COMPOSITOR=ON:
../../Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp: In member function ‘void WebKit::ThreadedCompositor::createCompositingThread()’:
../../Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:301:72: error: no matching function for call to ‘WTF::ThreadCondition::wait(WTF::Lock&)’
m_initializeRunLoopCondition.wait(m_initializeRunLoopConditionMutex);
^
../../Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:301:72: note: candidate is:
In file included from ../../Source/WTF/wtf/Threading.h:44:0,
from ../../Source/WebCore/platform/Timer.h:32,
from ../../Source/WebCore/platform/graphics/FontCache.h:34,
from ../../Source/WebCore/platform/graphics/freetype/FontPlatformData.h:29,
from ../../Source/WebCore/platform/graphics/FontPlatformData.h:27,
from ../../Source/WebCore/platform/graphics/Font.h:30,
from ../../Source/WebCore/platform/graphics/FontCascade.h:29,
from ../../Source/WebCore/platform/graphics/GraphicsContext.h:33,
from DerivedSources/ForwardingHeaders/WebCore/GraphicsContext.h:1,
from ../../Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:27,
from ../../Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:31,
from ../../Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:29:
../../Source/WTF/wtf/ThreadingPrimitives.h:97:10: note: void WTF::ThreadCondition::wait(WTF::Mutex&)
WTF_EXPORT_PRIVATE void wait(Mutex& mutex);
^
../../Source/WTF/wtf/ThreadingPrimitives.h:97:10: note: no known conversion for argument 1 from ‘WTF::Lock’ to ‘WTF::Mutex&’
../../Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp: In member function ‘void WebKit::ThreadedCompositor::terminateCompositingThread()’:
../../Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:340:70: error: no matching function for call to ‘WTF::ThreadCondition::wait(WTF::Lock&)’
m_terminateRunLoopCondition.wait(m_terminateRunLoopConditionMutex);</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>